content/common/push_messaging_messages.h - Issue 793403002: Implement WebPushProvider.unregister() in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/push_messaging_messages.h

Issue 793403002: Implement WebPushProvider.unregister() in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mvan_2

Patch Set: review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/push_messaging/push_provider.cc ('K') | « content/common/DEPS ('k') | content/public/browser/push_messaging_service.h » ('j') | content/public/browser/push_messaging_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/push_messaging_messages.h

diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h

index 9f93507b277800f5cd6ba8688976d6590fbc5109..e6e539ecf992e4b8e9f73d79f943d4435cb09d6c 100644

--- a/content/common/push_messaging_messages.h

+++ b/content/common/push_messaging_messages.h

@@ -7,6 +7,7 @@

#include "content/public/common/push_messaging_status.h"

#include "ipc/ipc_message_macros.h"

+#include "third_party/WebKit/public/platform/WebPushError.h"

#include "third_party/WebKit/public/platform/WebPushPermissionStatus.h"

#include "url/gurl.h"

@@ -22,6 +23,10 @@ IPC_ENUM_TRAITS_MAX_VALUE(

blink::WebPushPermissionStatus,

blink::WebPushPermissionStatus::WebPushPermissionStatusLast)

+IPC_ENUM_TRAITS_MAX_VALUE(

+ blink::WebPushError::ErrorType,

+ blink::WebPushError::ErrorType::ErrorTypeLast)

// Messages sent from the browser to the child process.

IPC_MESSAGE_ROUTED3(PushMessagingMsg_RegisterFromDocumentSuccess,

@@ -67,6 +72,15 @@ IPC_MESSAGE_ROUTED1(PushMessagingMsg_PermissionStatusFailure,

IPC_MESSAGE_CONTROL1(PushMessagingMsg_GetPermissionStatusError,

int32 /* request_id */)

+IPC_MESSAGE_CONTROL2(PushMessagingMsg_UnregisterSuccess,

+ int32 /* request_id */,

+ bool /* did_unregister */)

+IPC_MESSAGE_CONTROL3(PushMessagingMsg_UnregisterError,

+ int32 /* request_id */,

+ blink::WebPushError::ErrorType /* error_type */,

+ std::string /* error_message */)

// Messages sent from the child process to the browser.

// TODO(mvanouwerkerk): Delete this when it is no longer used.

@@ -101,3 +115,7 @@ IPC_MESSAGE_CONTROL3(PushMessagingHostMsg_PermissionStatus,

IPC_MESSAGE_CONTROL2(PushMessagingHostMsg_GetPermissionStatus,

int32 /* request_id */,

int64 /* service_worker_registration_id */)

+IPC_MESSAGE_CONTROL2(PushMessagingHostMsg_Unregister,

+ int32 /* request_id */,

+ int64 /* service_worker_registration_id */)