sky/viewer/document_view.h - Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/viewer/document_view.h

Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/viewer/document_view.h

diff --git a/sky/viewer/document_view.h b/sky/viewer/document_view.h

index a5151b52ace1bcd531f282c2acdd9ef8b8a618b0..05509bcead672434639c0991f20ae6685c8c96f4 100644

--- a/sky/viewer/document_view.h

+++ b/sky/viewer/document_view.h

@@ -82,7 +82,7 @@ class DocumentView : public blink::ServiceProvider,

blink::WebScreenInfo screenInfo() override;

// WebFrameClient methods:

- mojo::View* createChildFrame(const blink::WebURL& url) override;

+ mojo::View* createChildFrame() override;

void frameDetached(blink::WebFrame*) override;

blink::WebNavigationPolicy decidePolicyForNavigation(

const blink::WebFrameClient::NavigationPolicyInfo& info) override;

« no previous file with comments | « sky/engine/web/FrameLoaderClientImpl.cpp ('k') | sky/viewer/document_view.cc » ('j') | no next file with comments »