Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 793383003: NaCl: Update revision in DEPS, r14178 -> r14201 (Closed)

Created:
6 years ago by grt (UTC plus 2)
Modified:
6 years ago
CC:
chromium-reviews, Derek Schuff, David Yen, hamaji, hidehiko, Karl, Nick Bray (chromium), Sam Clegg, shyamsundarr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r14178 -> r14201 This pulls in the following Native Client changes: r14179: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r14180: (ncbray) GN: fix layering of library dependencies. r14181: (shyamsundarr) enable all nonspecial avx1 instructions. r14183: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r14184: (dschuff) Use an architecture-specific newlib build for nacl-clang r14185: (dschuff) Make libc.a a linker script for nacl-clang r14186: (jvoung) Don't use pnacl raw toolchain in llvm nightly and libcxx tests. r14187: (hamaji) Non-SFI Mode: Build PIE nonsfi_loader r14188: (dschuff) Update revision for PNaCl r14173->r14185 r14189: (dschuff) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS r14190: (jvoung) Remove a few locale-related "known failures" from libcxx list. r14191: (dyen) NaCl Core SDK libs for both x86-32/x86-64 x86 newlib/glibc toolchains. r14192: (sbc) Update glibc version in tools/REVISIONS (f78e18e->1106743) r14193: (dyen) Fixed package_version reusing work dirs between revision packages. r14194: (ncbray) Roll GCC toolchains. r14195: (hidehiko) Non-SFI mode: Override NACL_BUILD_ARCH and _SUBARCH in build_nexe.py. r14196: (dschuff) Remove cygwin support from buildbot_pnacl_toolchain.py r14197: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r14198: (sbc) ncval_new: on success don't produce any output by default. r14200: (ncbray) GN: do not assemble toolchain in output directory. r14201: (grt) Stop closing thread handles owned by the Win32 debugging API. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk Committed: https://crrev.com/838194227ff0c1a35a15d77cee8e1d76bd115070 Cr-Commit-Position: refs/heads/master@{#308091}

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (7 generated)
grt (UTC plus 2)
6 years ago (2014-12-11 15:31:54 UTC) #2
grt (UTC plus 2)
NaClBrowserTestPnacl.PnaclErrorHandling seems to be failing with this roll on linux_chromium_rel_ng. Any ideas from those with ...
6 years ago (2014-12-11 16:05:26 UTC) #3
jvoung - send to chromium...
On 2014/12/11 16:05:26, grt wrote: > NaClBrowserTestPnacl.PnaclErrorHandling seems to be failing with this roll on ...
6 years ago (2014-12-11 16:51:40 UTC) #4
grt (UTC plus 2)
On 2014/12/11 16:51:40, jvoung - send to chromium... wrote: > On 2014/12/11 16:05:26, grt wrote: ...
6 years ago (2014-12-11 18:38:37 UTC) #5
jvoung (off chromium)
LGTM thanks
6 years ago (2014-12-11 18:58:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793383003/20001
6 years ago (2014-12-11 21:01:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29827)
6 years ago (2014-12-11 21:07:19 UTC) #11
Mark Seaborn
LGTM
6 years ago (2014-12-11 21:10:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793383003/20001
6 years ago (2014-12-11 21:12:02 UTC) #14
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years ago (2014-12-12 09:03:19 UTC) #16
grt (UTC plus 2)
What do you NaCl experts make of the RemoteDebuggingTest.RemoteDebugger failure on linux_rel_precise32? Some interesting snippets ...
6 years ago (2014-12-12 14:16:26 UTC) #17
grt (UTC plus 2)
On 2014/12/12 14:16:26, grt wrote: > What do you NaCl experts make of the RemoteDebuggingTest.RemoteDebugger ...
6 years ago (2014-12-12 14:22:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793383003/20001
6 years ago (2014-12-12 15:07:55 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 16:00:08 UTC) #21
commit-bot: I haz the power
6 years ago (2014-12-12 16:00:51 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/838194227ff0c1a35a15d77cee8e1d76bd115070
Cr-Commit-Position: refs/heads/master@{#308091}

Powered by Google App Engine
This is Rietveld 408576698