Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 793343002: IDL parser: override Attribute production from base IDL parser (Closed)

Created:
6 years ago by Jens Widell
Modified:
6 years ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL parser: override Attribute production from base IDL parser The Attribute production is deprecated in the base IDL parser and is kept around only because Blink references it. It would be better to name this production ExceptionAttribute, but doing that now leaves the Attribute production in the base parser unused, which causes warnings. Overriding it here will let us remove it from the base parser without fuzz. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/bindings/scripts/blink_idl_parser.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL This is just a step in aligning the base parser's grammar to the spec. ...
6 years ago (2014-12-11 14:10:35 UTC) #2
haraken
LGTM
6 years ago (2014-12-11 14:23:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793343002/1
6 years ago (2014-12-11 14:24:27 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 15:39:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186957

Powered by Google App Engine
This is Rietveld 408576698