Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 793333003: Correct handling of exceptions occured during getting of exception stack trace. (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correct handling of exceptions occured during getting of exception stack trace. BUG=chromium:444805 LOG=Y Committed: https://crrev.com/0d6785805c10c9386fca88e07d5ddccd7aa180eb Cr-Commit-Position: refs/heads/master@{#25978}

Patch Set 1 #

Total comments: 1

Patch Set 2 : offline comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M src/api.cc View 1 1 chunk +9 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-444805.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-444805.js-script View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Igor Sheludko
PTAL
6 years ago (2014-12-23 15:38:48 UTC) #2
Yang
Lgtm https://codereview.chromium.org/793333003/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/793333003/diff/1/src/d8.cc#newcode606 src/d8.cc:606: reinterpret_cast<i::Isolate*>(isolate)->clear_pending_exception(); Can we assert that there is indeed ...
6 years ago (2014-12-23 22:16:10 UTC) #3
Igor Sheludko
PTAL
5 years, 11 months ago (2015-01-07 13:51:58 UTC) #5
Yang
On 2015/01/07 13:51:58, Igor Sheludko wrote: > PTAL LGTM! Thanks!
5 years, 11 months ago (2015-01-07 14:12:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793333003/40001
5 years, 11 months ago (2015-01-07 14:14:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-07 14:50:17 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 14:50:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d6785805c10c9386fca88e07d5ddccd7aa180eb
Cr-Commit-Position: refs/heads/master@{#25978}

Powered by Google App Engine
This is Rietveld 408576698