Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 79333002: Fix SkMatrix44::invert(...) for identity matrices and a NULL parameter (Closed)

Created:
7 years, 1 month ago by Ian Vollick
Modified:
7 years, 1 month ago
Reviewers:
ajuma, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix SkMatrix44::invert(...) for identity matrices and a NULL parameter Currently, to check if an SkMatrix44 is singular, we call ::invert(NULL) and check the result. Usually this does no more work than is necessary. One case where we do far too much work is if |this| is an identity matrix. In this case, we do not early out and compute a (partial) determinant (we don't do the full shebang because there are no perspective components). BUG=None Committed: http://code.google.com/p/skia/source/detail?r=12327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M src/utils/SkMatrix44.cpp View 1 chunk +17 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ian Vollick
+ajuma for correctness. +reed for OWNERS.
7 years, 1 month ago (2013-11-20 20:03:05 UTC) #1
ajuma
lgtm
7 years, 1 month ago (2013-11-20 20:06:19 UTC) #2
reed1
lgtm
7 years, 1 month ago (2013-11-20 20:19:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vollick@chromium.org/79333002/1
7 years, 1 month ago (2013-11-20 20:28:31 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 21:32:30 UTC) #5
Message was sent while issue was closed.
Change committed as 12327

Powered by Google App Engine
This is Rietveld 408576698