Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 793323003: Use GYP rules instead of actions to run mig (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M util/util.gyp View 2 chunks +34 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
I’m going to need to mig notify.defs also, and it’s not scalable for these actions ...
6 years ago (2014-12-11 15:04:35 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-11 15:56:39 UTC) #3
Mark Mentovai
6 years ago (2014-12-11 16:27:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
302c87c6e54775ca351979b69a083c7e914157ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698