Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 793263002: Remove extraneous needsRecalc condition. (Closed)

Created:
6 years ago by rune
Modified:
6 years ago
Reviewers:
andersr
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove extraneous needsRecalc condition. childNeedsDistributionRecalc() was added to the condition in r186599, but it is already checked inside needsFullRenderTreeUpdate(). Removing it again. R=andersr@opera.com BUG=436064 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186947

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
A LayoutTests/fast/css/getComputedStyle/computed-style-redistribution.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/getComputedStyle/computed-style-redistribution-expected.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
rune
6 years ago (2014-12-11 08:18:12 UTC) #1
andersr
lgtm
6 years ago (2014-12-11 08:27:57 UTC) #2
rune
On 2014/12/11 at 08:27:57, andersr wrote: > lgtm I forgot that I actually had a ...
6 years ago (2014-12-11 08:32:24 UTC) #3
andersr
On 2014/12/11 08:32:24, rune wrote: > On 2014/12/11 at 08:27:57, andersr wrote: > > lgtm ...
6 years ago (2014-12-11 09:56:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793263002/20001
6 years ago (2014-12-11 09:59:37 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 12:59:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186947

Powered by Google App Engine
This is Rietveld 408576698