Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 793243004: IDL: Properly support [Exposed] on static methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index d85af66a9df27bfc138543a65380a3b896213687..3403080dc766585bc54ddbc65b7324b1a50fa160 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -643,13 +643,19 @@ void {{v8_class_or_partial}}::installConditionallyEnabledMethods(v8::Handle<v8::
ASSERT(context);
{% for method in conditionally_enabled_methods %}
- {% filter per_context_enabled(method.per_context_enabled_function) %}
- {% filter exposed(method.exposed_test) %}
- {% filter runtime_enabled(method.overloads.runtime_enabled_function_all if method.overloads else method.runtime_enabled_function) %}
+ {% filter per_context_enabled(method.overloads.per_context_enabled_function_all
+ if method.overloads else
+ method.per_context_enabled_function) %}
+ {% filter exposed(method.overloads.exposed_test_all
+ if method.overloads else
+ method.exposed_test) %}
+ {% filter runtime_enabled(method.overloads.runtime_enabled_function_all
+ if method.overloads else
+ method.runtime_enabled_function) %}
prototypeObject->Set(v8AtomicString(isolate, "{{method.name}}"), v8::FunctionTemplate::New(isolate, {{cpp_class_or_partial}}V8Internal::{{method.name}}MethodCallback, v8Undefined(), defaultSignature, {{method.number_of_required_arguments}})->GetFunction());
- {% endfilter %}
- {% endfilter %}
- {% endfilter %}
+ {% endfilter %}{# runtime_enabled() #}
+ {% endfilter %}{# exposed() #}
+ {% endfilter %}{# per_context_enabled() #}
{% endfor %}
{% endif %}
}
« no previous file with comments | « Source/bindings/templates/interface_base.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698