Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 793243002: Restructure public side of content_handler service. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of content_handler service. This CL goes from this: //mojo/services/public/interfaces/content_handler to this: //mojo/services/content_handler/public/interfaces This CL also makes the Mojo-side changes necessary to roll this change into Chromium. TBR=beng Committed: https://chromium.googlesource.com/external/mojo/+/0a8605b299955f1d3b78afd55b0c8717d6c22490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -50 lines) Patch
M examples/content_handler_demo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/pdf_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/png_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application_manager/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/content_handler/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/content_handler/public/interfaces/content_handler.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/public/interfaces/content_handler/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M services/js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/content_handler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/viewer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
blundell
6 years ago (2014-12-11 07:15:33 UTC) #1
blundell
6 years ago (2014-12-11 07:16:18 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0a8605b299955f1d3b78afd55b0c8717d6c22490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698