Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: build/get_landmines.py

Issue 793203002: Use SuppressFBWarnings to suppress findbugs warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + landmine Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/findbugs_filter/findbugs_known_bugs.txt ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 22
23 def print_landmines(): 23 def print_landmines():
24 """ 24 """
25 ALL LANDMINES ARE EMITTED FROM HERE. 25 ALL LANDMINES ARE EMITTED FROM HERE.
26 """ 26 """
27 if (distributor() == 'goma' and platform() == 'win32' and 27 if (distributor() == 'goma' and platform() == 'win32' and
28 builder() == 'ninja'): 28 builder() == 'ninja'):
29 print 'Need to clobber winja goma due to backend cwd cache fix.' 29 print 'Need to clobber winja goma due to backend cwd cache fix.'
30 if platform() == 'android': 30 if platform() == 'android':
31 print 'Clobber: To delete newly generated mojo class files.' 31 print 'Clobber: to handle new way of suppressing findbugs failures.'
32 print 'Clobber to ensure that recipe tests do not break (issue 680923002).'
33 if platform() == 'win' and builder() == 'ninja': 32 if platform() == 'win' and builder() == 'ninja':
34 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 33 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
35 if platform() == 'linux' and builder() == 'ninja': 34 if platform() == 'linux' and builder() == 'ninja':
36 print 'Builders switching from make to ninja will clobber on this.' 35 print 'Builders switching from make to ninja will clobber on this.'
37 if platform() == 'mac': 36 if platform() == 'mac':
38 print 'Switching from bundle to unbundled dylib (issue 14743002).' 37 print 'Switching from bundle to unbundled dylib (issue 14743002).'
39 if platform() in ('win', 'mac'): 38 if platform() in ('win', 'mac'):
40 print ('Improper dependency for create_nmf.py broke in r240802, ' 39 print ('Improper dependency for create_nmf.py broke in r240802, '
41 'fixed in r240860.') 40 'fixed in r240860.')
42 if (platform() == 'win' and builder() == 'ninja' and 41 if (platform() == 'win' and builder() == 'ninja' and
43 gyp_msvs_version() == '2012' and 42 gyp_msvs_version() == '2012' and
44 gyp_defines().get('target_arch') == 'x64' and 43 gyp_defines().get('target_arch') == 'x64' and
45 gyp_defines().get('dcheck_always_on') == '1'): 44 gyp_defines().get('dcheck_always_on') == '1'):
46 print "Switched win x64 trybots from VS2010 to VS2012." 45 print "Switched win x64 trybots from VS2010 to VS2012."
47 if (platform() == 'win' and builder() == 'ninja' and 46 if (platform() == 'win' and builder() == 'ninja' and
48 gyp_msvs_version().startswith('2013')): 47 gyp_msvs_version().startswith('2013')):
49 print "Switched win from VS2010 to VS2013." 48 print "Switched win from VS2010 to VS2013."
50 print "Update to VS2013 Update 2." 49 print "Update to VS2013 Update 2."
51 print "Update to VS2013 Update 4." 50 print "Update to VS2013 Update 4."
52 print 'Need to clobber everything due to an IDL change in r154579 (blink)' 51 print 'Need to clobber everything due to an IDL change in r154579 (blink)'
53 print 'Need to clobber everything due to gen file moves in r175513 (Blink)' 52 print 'Need to clobber everything due to gen file moves in r175513 (Blink)'
54 if (platform() != 'ios'): 53 if (platform() != 'ios'):
55 print 'Clobber to get rid of obselete test plugin after r248358' 54 print 'Clobber to get rid of obselete test plugin after r248358'
56 print 'Clobber to rebuild GN files for V8' 55 print 'Clobber to rebuild GN files for V8'
57 print 'Need to clobber everything due to build_nexe change in nacl r13424' 56 print 'Need to clobber everything due to build_nexe change in nacl r13424'
58 print '[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...' 57 print '[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...'
59 print 'blink_resources.grd changed: crbug.com/400860' 58 print 'blink_resources.grd changed: crbug.com/400860'
60 print 'ninja dependency cycle: crbug.com/408192' 59 print 'ninja dependency cycle: crbug.com/408192'
61 if platform() == 'android':
62 print 'Delete stale generated .java files yet again. crbug.com/349592'
63 print 'Clobber to delete incompatible object binary format with NDK r10c'
64 print 'Clobber to fix missing NaCl gyp dependencies (crbug.com/427427).' 60 print 'Clobber to fix missing NaCl gyp dependencies (crbug.com/427427).'
65 print 'Another clobber for missing NaCl gyp deps (crbug.com/427427).' 61 print 'Another clobber for missing NaCl gyp deps (crbug.com/427427).'
66 print 'Clobber to fix GN not picking up increased ID range (crbug.com/444902)' 62 print 'Clobber to fix GN not picking up increased ID range (crbug.com/444902)'
67 63
68 64
69 def main(): 65 def main():
70 print_landmines() 66 print_landmines()
71 return 0 67 return 0
72 68
73 69
74 if __name__ == '__main__': 70 if __name__ == '__main__':
75 sys.exit(main()) 71 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/findbugs_filter/findbugs_known_bugs.txt ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698