Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 793153004: Add 'depfile' option to actions. (Closed)

Created:
6 years ago by teravest
Modified:
5 years, 11 months ago
Reviewers:
bradn
CC:
gyp-developer_googlegroups.com
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Add 'depfile' option to actions. This adds a 'depfile' option to GYP actions, which allows an action to provide that 'depfile' for use by ninja. This is necessary for handling dependencies correctly when an action compiles generated code. BUG=https://code.google.com/p/chromium/issues/detail?id=440451 R=bradnelson@google.com Committed: https://code.google.com/p/gyp/source/detail?r=2024

Patch Set 1 #

Patch Set 2 : Add gyp test #

Total comments: 4

Patch Set 3 : Fix copyright year and trailing newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M pylib/gyp/generator/ninja.py View 3 chunks +9 lines, -3 lines 0 comments Download
A test/actions-depfile/depfile.gyp View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A test/actions-depfile/gyptest-all.py View 1 1 chunk +20 lines, -0 lines 0 comments Download
A + test/actions-depfile/input.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bradn
A gyp system test would definitely be a good idea here. There's a test suite ...
5 years, 11 months ago (2015-01-03 21:34:42 UTC) #2
teravest
I've added a gyp test, though it just makes sure that the right "depfile = ...
5 years, 11 months ago (2015-01-14 21:18:58 UTC) #3
bradn
lgtm https://codereview.chromium.org/793153004/diff/20001/test/actions-depfile/depfile.gyp File test/actions-depfile/depfile.gyp (right): https://codereview.chromium.org/793153004/diff/20001/test/actions-depfile/depfile.gyp#newcode1 test/actions-depfile/depfile.gyp:1: # Copyright (c) 2014 Google Inc. All rights ...
5 years, 11 months ago (2015-01-15 01:07:07 UTC) #4
teravest
https://codereview.chromium.org/793153004/diff/20001/test/actions-depfile/depfile.gyp File test/actions-depfile/depfile.gyp (right): https://codereview.chromium.org/793153004/diff/20001/test/actions-depfile/depfile.gyp#newcode1 test/actions-depfile/depfile.gyp:1: # Copyright (c) 2014 Google Inc. All rights reserved. ...
5 years, 11 months ago (2015-01-15 15:36:54 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-15 16:12:49 UTC) #8
teravest
Brad, can you grant me committer status in the gyp project? (Or, alternately, commit this ...
5 years, 11 months ago (2015-01-15 16:33:33 UTC) #9
teravest
5 years, 11 months ago (2015-01-16 16:04:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 2024 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698