Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 793083002: Add dpranke, scottmg as owners for GN-related files in src/build. (Closed)

Created:
6 years ago by Dirk Pranke
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add dpranke, scottmg as owners for GN-related files in src/build. Also, remove the 'set noparent'; that was probably useful when build/OWNERS had a wildcard, but it doesn't any more. R=brettw@chromium.org BUG= Committed: https://crrev.com/3bce201c67c641d29f78960ebcf84b5c24467e16 Cr-Commit-Position: refs/heads/master@{#308133}

Patch Set 1 #

Patch Set 2 : keep brettw as the only owner of build/config/BUILDCONFIG.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/config/OWNERS View 1 1 chunk +5 lines, -1 line 0 comments Download
M build/toolchain/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (1 generated)
Dirk Pranke
6 years ago (2014-12-10 23:23:22 UTC) #1
brettw
Is it possible to do this but have me be the only owner of BUILDCONFIG.gn? ...
6 years ago (2014-12-12 00:52:24 UTC) #2
scottmg
On 2014/12/12 00:52:24, brettw wrote: > Is it possible to do this but have me ...
6 years ago (2014-12-12 01:11:44 UTC) #3
Dirk Pranke
On 2014/12/12 01:11:44, scottmg wrote: > On 2014/12/12 00:52:24, brettw wrote: > > Is it ...
6 years ago (2014-12-12 01:45:33 UTC) #4
Dirk Pranke
Okay, added. Please take another look? Though I don't really like the idea of *any* ...
6 years ago (2014-12-12 02:46:00 UTC) #5
brettw
Additions to BUILDCONFIG are almost always wrong and if somebody thinks they really need to ...
6 years ago (2014-12-12 05:35:55 UTC) #6
brettw
lgtm
6 years ago (2014-12-12 05:36:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793083002/20001
6 years ago (2014-12-12 18:05:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 18:56:32 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 18:57:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bce201c67c641d29f78960ebcf84b5c24467e16
Cr-Commit-Position: refs/heads/master@{#308133}

Powered by Google App Engine
This is Rietveld 408576698