Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 793013003: Remove the low hanging fruit with coord change matrices (Closed)

Created:
6 years ago by joshua.litt
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@more-ccm-cleanup
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove the low hanging fruit with coord change matrices BUG=skia: Committed: https://skia.googlesource.com/skia/+/c2625821b34d89e8df2ba89cc84db6957189f250

Patch Set 1 #

Patch Set 2 : comment cleanup #

Total comments: 1

Patch Set 3 : comments updated #

Patch Set 4 : adding tests to ignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/GrPaint.h View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joshualitt
These were the easy cases
6 years ago (2014-12-18 20:53:51 UTC) #3
bsalomon
lgtm, but I think the comment should just reflect that the glyph may be very ...
6 years ago (2014-12-18 21:03:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793013003/60001
6 years ago (2014-12-19 00:32:41 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/c2625821b34d89e8df2ba89cc84db6957189f250
6 years ago (2014-12-19 00:40:59 UTC) #7
jvanverth1
6 years ago (2014-12-19 13:36:54 UTC) #8
Message was sent while issue was closed. 
On 2014/12/18 21:03:04, bsalomon wrote:
> lgtm, but I think the comment should just reflect that the glyph may be very
> large
> 
>
https://codereview.chromium.org/793013003/diff/20001/src/gpu/GrBitmapTextCont...
> File src/gpu/GrBitmapTextContext.cpp (right):
> 
>
https://codereview.chromium.org/793013003/diff/20001/src/gpu/GrBitmapTextCont...
> src/gpu/GrBitmapTextContext.cpp:433: // If the font is too large, we fall back
> to paths in SkGpuDevice.  However, its possible for
> Not just possible for corrupted fonts...

Sorry, I missed this. It can also fail because the backing texture failed to be
created, or because we couldn't make room in the atlas for a new glyph (which
shouldn't happen, but if something broke somewhere else it's something we have
to recover from). I'll update the comment at some point.

Powered by Google App Engine
This is Rietveld 408576698