Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 793013002: win: Add compat header for sys/types.h (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

win: Add compat header for sys/types.h To add definition of ssize_t. Uses #include <../include/...> to emulate #include_next, similar to the mac headers. BUG=crashpad:1 R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/012ddc9752e6a9d43a295e7f2423a23b56487dcb

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix whitespace, no copy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M compat/compat.gyp View 2 chunks +11 lines, -1 line 0 comments Download
A compat/win/sys/types.h View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
scottmg
6 years ago (2014-12-10 19:26:47 UTC) #2
Mark Mentovai
Cool trick. LGTM otherwise. https://codereview.chromium.org/793013002/diff/1/compat/win/sys/types.h File compat/win/sys/types.h (right): https://codereview.chromium.org/793013002/diff/1/compat/win/sys/types.h#newcode1 compat/win/sys/types.h:1: // Copyright 2014 The Crashpad ...
6 years ago (2014-12-10 19:33:04 UTC) #3
scottmg
https://codereview.chromium.org/793013002/diff/1/compat/win/sys/types.h File compat/win/sys/types.h (right): https://codereview.chromium.org/793013002/diff/1/compat/win/sys/types.h#newcode1 compat/win/sys/types.h:1: // Copyright 2014 The Crashpad Authors. All rights reserved. ...
6 years ago (2014-12-10 19:39:24 UTC) #8
scottmg
6 years ago (2014-12-10 19:39:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:100001) manually as
012ddc9752e6a9d43a295e7f2423a23b56487dcb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698