Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 793003004: MacViews: Implement event monitoring for a specific window (Reland) (Closed)

Created:
6 years ago by Andre
Modified:
6 years ago
Reviewers:
tapted, sky
CC:
chromium-reviews, sadrul, tdresser+watch_chromium.org, tfarina, dcheng, kalyank, gcasto+watchlist_chromium.org, jdduke+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Implement event monitoring for a specific window (Reland) ManagePasswordBubbleView wants to monitor events on a specific window, currently using aura specific code that won't work for MacViews. views::EventMonitor is enhanced to support monitoring events on a window, with both Mac and Aura implementations. Also includes minor compile fixes in ZoomBubbleView and StatusBubbleView. Originally reviewed in https://crrev.com/730833006/ BUG=425229 Committed: https://crrev.com/5fa7a281e925c9320d86a80e463998ffaf6e51eb Cr-Commit-Position: refs/heads/master@{#308112}

Patch Set 1 : Original reverted patch #

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -138 lines) Patch
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 6 chunks +9 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/event_generator_delegate_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/test/event_generator.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/events/test/event_generator.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M ui/views/event_monitor.h View 2 chunks +17 lines, -3 lines 0 comments Download
M ui/views/event_monitor_aura.h View 1 chunk +7 lines, -1 line 0 comments Download
M ui/views/event_monitor_aura.cc View 2 chunks +20 lines, -6 lines 0 comments Download
M ui/views/event_monitor_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/event_monitor_mac.mm View 3 chunks +23 lines, -9 lines 0 comments Download
D ui/views/event_monitor_mac_unittest.mm View 1 chunk +0 lines, -67 lines 0 comments Download
A ui/views/event_monitor_unittest.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
M ui/views/mouse_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/event_generator_delegate_mac.mm View 4 chunks +24 lines, -21 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Andre
Trent, Scott, PTAL. There was a bug in the test code, the target window need ...
6 years ago (2014-12-12 02:15:18 UTC) #2
tapted
lgtm I would just add "Originally reviewed in http://crrev.com/730833006/" to the CL description. (Aaand.. opinions ...
6 years ago (2014-12-12 02:34:30 UTC) #3
sky
LGTM
6 years ago (2014-12-12 15:51:44 UTC) #4
Andre
On 2014/12/12 02:34:30, tapted wrote: > lgtm > > I would just add > > ...
6 years ago (2014-12-12 16:36:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793003004/20001
6 years ago (2014-12-12 16:36:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 17:36:21 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 17:38:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fa7a281e925c9320d86a80e463998ffaf6e51eb
Cr-Commit-Position: refs/heads/master@{#308112}

Powered by Google App Engine
This is Rietveld 408576698