Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: build/standalone.gypi

Issue 792953005: Resolve all but two VC++ build warnings in pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Only do warnings-as-errors on 32-bit builds. Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/src/fpdftext/fpdf_text_int.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index d335f05e49c5ce1b6c597f387eb8c60764b889e7..5271350e831125ed60e98c68c835659f617572eb 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -165,6 +165,7 @@
'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
'CharacterSet': '1',
},
+ 'msvs_disabled_warnings': [4800],
'msvs_settings': {
'VCCLCompilerTool': {
'MinimalRebuild': 'false',
@@ -172,7 +173,6 @@
'EnableFunctionLevelLinking': 'true',
'RuntimeTypeInfo': 'false',
'WarningLevel': '3',
- 'WarnAsError': 'false',
'DebugInformationFormat': '3',
'Detect64BitPortabilityProblems': 'false',
'conditions': [
@@ -184,6 +184,12 @@
}, {
'ExceptionHandling': '0',
}],
+ ['target_arch=="x64"', {
+ 'WarnAsError': 'false',
Tom Sepez 2015/01/05 23:02:57 nit: indent +4 ? Strange, I thought that [ and {
brucedawson 2015/01/06 18:03:32 There's a sort of logic to having two scoping deli
+ }, {
+ 'WarnAsError': 'true',
+ }
Tom Sepez 2015/01/05 23:02:57 nit: prefer }], on same line.
brucedawson 2015/01/06 18:03:32 Fixed. And added the missing comma.
+ ]
],
},
'VCLibrarianTool': {
« no previous file with comments | « no previous file | core/src/fpdftext/fpdf_text_int.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698