Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: pdfium.gyp

Issue 792953005: Resolve all but two VC++ build warnings in pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Link to warning bugs, and globally suppress 4996 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/src/fpdftext/fpdf_text_int.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'pdf_use_skia%': 0, 3 'pdf_use_skia%': 0,
4 }, 4 },
5 'target_defaults': { 5 'target_defaults': {
6 'defines' : [ 6 'defines' : [
7 'FT2_BUILD_LIBRARY', 7 'FT2_BUILD_LIBRARY',
8 '_FPDFSDK_LIB', 8 '_FPDFSDK_LIB',
9 '_NO_GDIPLUS_', # workaround text rendering issues on Windows 9 '_NO_GDIPLUS_', # workaround text rendering issues on Windows
10 'OPJ_STATIC', 10 'OPJ_STATIC',
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 'core/src/fpdftext/unicodenormalization.cpp', 301 'core/src/fpdftext/unicodenormalization.cpp',
302 'core/src/fpdftext/unicodenormalizationdata.cpp', 302 'core/src/fpdftext/unicodenormalizationdata.cpp',
303 ], 303 ],
304 }, 304 },
305 { 305 {
306 'target_name': 'fxcodec', 306 'target_name': 'fxcodec',
307 'type': 'static_library', 307 'type': 'static_library',
308 'include_dirs': [ 308 'include_dirs': [
309 ], 309 ],
310 'ldflags': [ '-L<(PRODUCT_DIR)',], 310 'ldflags': [ '-L<(PRODUCT_DIR)',],
311 'msvs_settings': {
312 'VCCLCompilerTool': {
313 # Unresolved warnings in fx_codec_jpx_opj.cpp
314 # https://code.google.com/p/pdfium/issues/detail?id=100
315 'WarnAsError': 'false',
Nico 2015/06/09 15:51:39 Please don't add WarnAsError: false anywhere, ever
316 },
317 },
311 'sources': [ 318 'sources': [
312 'core/include/fxcodec/fx_codec.h', 319 'core/include/fxcodec/fx_codec.h',
313 'core/include/fxcodec/fx_codec_def.h', 320 'core/include/fxcodec/fx_codec_def.h',
314 'core/include/fxcodec/fx_codec_provider.h', 321 'core/include/fxcodec/fx_codec_provider.h',
315 'core/src/fxcodec/codec/codec_int.h', 322 'core/src/fxcodec/codec/codec_int.h',
316 'core/src/fxcodec/codec/fx_codec.cpp', 323 'core/src/fxcodec/codec/fx_codec.cpp',
317 'core/src/fxcodec/codec/fx_codec_fax.cpp', 324 'core/src/fxcodec/codec/fx_codec_fax.cpp',
318 'core/src/fxcodec/codec/fx_codec_flate.cpp', 325 'core/src/fxcodec/codec/fx_codec_flate.cpp',
319 'core/src/fxcodec/codec/fx_codec_icc.cpp', 326 'core/src/fxcodec/codec/fx_codec_icc.cpp',
320 'core/src/fxcodec/codec/fx_codec_jbig.cpp', 327 'core/src/fxcodec/codec/fx_codec_jbig.cpp',
(...skipping 491 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 ], 819 ],
813 'include_dirs': [ 820 'include_dirs': [
814 '<(DEPTH)' 821 '<(DEPTH)'
815 ], 822 ],
816 'sources': [ 823 'sources': [
817 'core/src/fxcrt/fx_basic_bstring_unittest.cpp', 824 'core/src/fxcrt/fx_basic_bstring_unittest.cpp',
818 ], 825 ],
819 }, 826 },
820 ], 827 ],
821 } 828 }
OLDNEW
« no previous file with comments | « core/src/fpdftext/fpdf_text_int.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698