Issue 792953003: Visit all components of dotted library name. Fixes #109.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 792953003: Visit all components of dotted library name. Fixes #109. (Closed)

Created:
5 years, 11 months ago by Bob Nystrom

Modified:
5 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Visit all components of dotted library name. Fixes #109. BUG=https://github.com/dart-lang/dart_style/issues/109 R=sigmund@google.com Committed: 6f6969fd9bcba785784462cacedad6cd079acee7

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -3 lines)			Patch
M	lib/src/source_visitor.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	test/comments/top_level.unit	View	1 chunk	+21 lines, -1 line	0 comments	Download
A	test/regression/109.unit	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/whitespace/directives.unit	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

Hey, Siggy, you're one of the few people around today. Mind taking a look at ...

5 years, 11 months ago (2014-12-29 17:11:28 UTC) #2

Bob Nystrom

5 years, 11 months ago (2014-12-29 18:13:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f6969fd9bcba785784462cacedad6cd079acee7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages