Issue 792933003: Add checks to GitSanityChecks (upstream branch or current branch can be None)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 792933003: Add checks to GitSanityChecks (upstream branch or current branch can be None) (Closed)

Created:
6 years ago by Sam Clegg

Modified:
5 years, 11 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Add checks to GitSanityChecks (upstream branch or current branch can be None) I've run in the exceptions a few times when doing 'git cl presubmit' or 'git cl lint' from a detached HEAD state (not uncommon when using 'git rebase-update') Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293643

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	git_cl.py	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	git_common.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

iannucci

oh! didn't see this. This lgtm. Mention it to the sheriffs and keep an ear ...

5 years, 11 months ago (2015-01-13 20:31:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792933003/1

5 years, 11 months ago (2015-01-14 21:15:08 UTC) #6

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 21:18:14 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293643

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages