Issue 792883008: Deflake flights-app-pixels.sky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 792883008: Deflake flights-app-pixels.sky. (Closed)

Created:
5 years, 11 months ago by ojan

Modified:
5 years, 11 months ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Deflake flights-app-pixels.sky. We were dumping pixels before the images loaded. Instead, dig into the shadow root and only dump the pixels once all the images have loaded. This isn't an awesome solution for a real app, but it's good enough to deflake this test since all the images happen to be one shadow root deep. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08a034de7c528512e0096a9315e9e326ca0dff0b

Patch Set 1 #

Patch Set 2 : merge to ToT #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
	M	sky/tests/framework/flights-app-pixels.sky	View	1	1 chunk	+22 lines, -3 lines	0 comments	Download
	M	sky/tests/framework/flights-app-pixels-expected.sky	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

5 years, 11 months ago (2015-01-10 03:05:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
08a034de7c528512e0096a9315e9e326ca0dff0b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages