Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 792883006: Fix crash after Launcher drag/drop (take 2) (Closed)

Created:
6 years ago by Greg Levin
Modified:
6 years ago
Reviewers:
jennyz
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash after Launcher drag/drop (take 2) BUG=439055 TEST=In Launcher, drag app to solitary folder on second page This is a retry of https://codereview.chromium.org/780023002/ , which was reverted after commit due to a failed valgrind test. Committed: https://crrev.com/62e30ca368387d4edbbbf5c721f30881586b2387 Cr-Commit-Position: refs/heads/master@{#309235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -19 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 4 chunks +71 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Greg Levin
https://codereview.chromium.org/780023002/ was reverted by https://codereview.chromium.org/806883004 when valgrind bot failed. The slow speed of valgrind was ...
6 years ago (2014-12-19 18:03:09 UTC) #2
jennyz
lgtm
6 years ago (2014-12-19 18:20:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792883006/1
6 years ago (2014-12-19 18:24:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 19:56:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/62e30ca368387d4edbbbf5c721f30881586b2387 Cr-Commit-Position: refs/heads/master@{#309235}
6 years ago (2014-12-19 19:56:52 UTC) #7
benwells
6 years ago (2014-12-22 02:52:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/820943003/ by benwells@chromium.org.

The reason for reverting is: The new test is still causing problems. See
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v....

The test appears to be flaky. It has failed on that bot on 4 of the 6 runs since
this change landed.

BTW I'd add calamity@ to any reviews of dragging in the launcher as he has fixed
many bugs there and is aware of many subtleties in the code..

Powered by Google App Engine
This is Rietveld 408576698