content/renderer/pepper/resource_creation_impl.cc - Issue 792873004: Win32k lockdown: move to chrome://flags, add UMA, add finch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/resource_creation_impl.cc

Issue 792873004: Win32k lockdown: move to chrome://flags, add UMA, add finch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add flags to LoginCustomFlags Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/content_switches.cc ('K') | « content/renderer/pepper/content_renderer_pepper_host_factory.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/resource_creation_impl.cc

diff --git a/content/renderer/pepper/resource_creation_impl.cc b/content/renderer/pepper/resource_creation_impl.cc

index 4a693256ae0bed669f87885196139e1d6d3c2e70..ac5ee99ae660f26810274d0942ec98c1cae57549 100644

--- a/content/renderer/pepper/resource_creation_impl.cc

+++ b/content/renderer/pepper/resource_creation_impl.cc

@@ -140,8 +140,7 @@ PP_Resource ResourceCreationImpl::CreateImageData(PP_Instance instance,

// TODO(ananta)

// Look into whether this causes a loss of functionality. From cursory

// testing things seem to work well.

- if (CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kEnableWin32kRendererLockDown) &&

+ if (switches::Win32kRendererLockdownEnabled() &&

base::win::GetVersion() >= base::win::VERSION_WIN8) {

return CreateImageDataSimple(instance, format, size, init_to_zero);

}