Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: mojo/PRESUBMIT_test.py

Issue 792843002: Refactor the python system_impl module. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/PRESUBMIT.py ('k') | mojo/public/python/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/PRESUBMIT_test.py
diff --git a/mojo/PRESUBMIT_test.py b/mojo/PRESUBMIT_test.py
index 5245b68bb2a4841c09ef6b144e3b28d661d9e64e..4c677730c33b9ef7b6bdc7d17b55d552526f2064 100755
--- a/mojo/PRESUBMIT_test.py
+++ b/mojo/PRESUBMIT_test.py
@@ -201,6 +201,16 @@ class SourceSetTypesInBuildFilesTest(unittest.TestCase):
self.assertEqual(1, len(warnings))
self.checkWarningWithSingleItem(warnings[0], 'SDK', _SDK_BUILD_FILE, 2)
+ def testPythonSourceSetInSDKBuildFile(self):
+ """Tests that a python_binary_source_set within an SDK buildfile is
+ accepted."""
+ mock_input_api = self.inputApiContainingFileWithSourceSets(
+ _SDK_BUILD_FILE,
+ [ 'mojo_sdk_source_set(', 'python_binary_source_set(' ])
+ warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi())
+
+ self.assertEqual(0, len(warnings))
+
def testEDKSourceSetInSDKBuildFile(self):
"""Tests that a mojo_edk_source_set within an SDK buildfile is flagged."""
mock_input_api = self.inputApiContainingFileWithSourceSets(
« no previous file with comments | « mojo/PRESUBMIT.py ('k') | mojo/public/python/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698