Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: mojo/public/python/BUILD.gn

Issue 792843002: Refactor the python system_impl module. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fixes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/python/mojo/c_async_waiter.pxd » ('j') | mojo/public/python/mojo/system.pyx » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/python/BUILD.gn
diff --git a/mojo/public/python/BUILD.gn b/mojo/public/python/BUILD.gn
index 51bd6eb8599aaf0bf67ed84503be83fb63f3bca9..626def869e2e47940ce24d9eeeff635724e62060 100644
--- a/mojo/public/python/BUILD.gn
+++ b/mojo/public/python/BUILD.gn
@@ -16,44 +16,65 @@ group("python") {
# GYP version: mojo.gyp:mojo_python_system
python_binary_module("system") {
python_base_module = "mojo"
- sources = [
+ configs = [ "../build/config:mojo_sdk" ]
+ deps = [
+ ":system_embedded",
+ ]
+}
+
+python_binary_source_set("system_embedded") {
+ cython_sources = [
+ "mojo/c_async_waiter.pxd",
"mojo/c_core.pxd",
+ "mojo/c_thunks.pxd",
"mojo/system.pyx",
]
- configs = [ "../build/config:mojo_sdk" ]
deps = [
- ":base",
- "../c/environment",
"../c/system",
- "../cpp/environment:standalone",
+ "../cpp/bindings:callback",
"../cpp/system",
"../cpp/utility",
- "../cpp/bindings:callback",
"../platform/native:system",
+ ":base",
qsr 2014/12/12 14:27:06 Local dependencies must be first. Here and below
etiennej 2014/12/12 15:29:36 Done.
]
}
python_binary_module("system_impl") {
python_base_module = "mojo"
- sources = [
- "mojo/c_core.pxd",
+ cython_sources = [
"mojo/c_environment.pxd",
+ "mojo/c_thunks.pxd",
"mojo/system_impl.pyx",
]
- additional_sources = [
+ sources = [
"src/python_system_helper.cc",
"src/python_system_helper.h",
]
configs = [ "../build/config:mojo_sdk" ]
deps = [
- ":base",
"../c/environment",
"../c/system",
+ "../cpp/bindings:callback",
"../cpp/environment:standalone",
"../cpp/system",
"../cpp/utility",
- "../cpp/bindings:callback",
"../platform/native:system",
+ ":base",
+ ":python_common",
+ ]
+}
+
+python_binary_source_set("python_common") {
+ sources = [
+ "src/common.cc",
+ "src/common.h",
+ ]
+ deps = [
+ "../c/environment:environment",
+ "../cpp/bindings:callback",
+ "../cpp/environment:environment",
+ "../cpp/system:system",
+ "../cpp/utility",
]
}
« no previous file with comments | « no previous file | mojo/public/python/mojo/c_async_waiter.pxd » ('j') | mojo/public/python/mojo/system.pyx » ('J')

Powered by Google App Engine
This is Rietveld 408576698