Refactor the python system_impl module.

mojo/public/python/BUILD.gn

Index: mojo/public/python/BUILD.gn
diff --git a/mojo/public/python/BUILD.gn b/mojo/public/python/BUILD.gn
index 8f10250dc1ab0270474788fda61ab507bcd2355b..1b768d33cefb71183ef01930715110197a360a07 100644
--- a/mojo/public/python/BUILD.gn
+++ b/mojo/public/python/BUILD.gn
@@ -18,9 +18,9 @@ python_binary_module("system") {
   python_base_module = "mojo"
   sources = [
     "mojo/c_core.pxd",
+    "mojo/c_environment_common.pxd",
     "mojo/system.pyx",
   ]
-  configs = [ "../build/config:mojo_sdk" ]

[qsr, 2014/12/10 15:38:57]

You need to keep those.

[etiennej, 2014/12/11 09:52:52]

Done.

   deps = [
     ":base",
     "../c/environment",
@@ -32,6 +32,21 @@ python_binary_module("system") {
   ]
 }
 
+python_binary_module_sources("system_src") {

[qsr, 2014/12/10 15:38:57]

why are the dependencies different for this one and for system? If you can
remove dependency here, you can probably remove those for system.

Once this is the case, you might want to have those files and dependencies in
variables, and using those for both targets. And maybe, rework with the gni so
that you can not have any sources at all, and just depend on the source module
in the binary module.

Also, maybe rename system_src to system_embedded

[etiennej, 2014/12/11 09:52:52]

Done.

+  sources = [
+    "mojo/c_core.pxd",
+    "mojo/c_environment_common.pxd",
+    "mojo/system.pyx",
+  ]
+  deps = [
+    ":base",
+    "../c/system:for_shared_library",
+    "../cpp/system",
+    "../cpp/utility",
+    "../cpp/bindings:callback",
+  ]
+}
+
 python_binary_module("system_impl") {
   python_base_module = "mojo"
   sources = [
@@ -43,9 +58,9 @@ python_binary_module("system_impl") {
     "src/python_system_helper.cc",
     "src/python_system_helper.h",
   ]
-  configs = [ "../build/config:mojo_sdk" ]
   deps = [
     ":base",
+    ":python_common",
     "../c/environment",
     "../c/system:for_shared_library",
     "../cpp/environment:standalone",
@@ -55,6 +70,21 @@ python_binary_module("system_impl") {
   ]
 }
 
+source_set("python_common") {
+  sources = [
+    "src/common.h",
+    "src/common.cc",
+  ]
+  deps = [
+    "../c/environment:environment",
+    "../cpp/bindings:callback",
+    "../cpp/environment:environment",
+    "../cpp/system:system",
+    "../cpp/utility",
+  ]
+  include_dirs = [ "/usr/include/python2.7" ]

[qsr, 2014/12/10 15:38:57]

That's incorrect. You need to work with the rules.gni in cython, and use some
configuration from this so that this could work on other platform than linux or
with distribution that have python at some other place.

[etiennej, 2014/12/11 09:52:52]

Done.

+}
+
 copy("base") {
   sources = [
     "mojo/__init__.py",