Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: mojo/PRESUBMIT_test.py

Issue 792843002: Refactor the python system_impl module. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import os 6 import os
7 import sys 7 import sys
8 import unittest 8 import unittest
9 9
10 import PRESUBMIT 10 import PRESUBMIT
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 def testNakedSourceSetInSDKBuildFile(self): 194 def testNakedSourceSetInSDKBuildFile(self):
195 """Tests that a source_set within an SDK buildfile is flagged.""" 195 """Tests that a source_set within an SDK buildfile is flagged."""
196 mock_input_api = self.inputApiContainingFileWithSourceSets( 196 mock_input_api = self.inputApiContainingFileWithSourceSets(
197 _SDK_BUILD_FILE, 197 _SDK_BUILD_FILE,
198 [ 'mojo_sdk_source_set(', 'source_set(' ]) 198 [ 'mojo_sdk_source_set(', 'source_set(' ])
199 warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi()) 199 warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi())
200 200
201 self.assertEqual(1, len(warnings)) 201 self.assertEqual(1, len(warnings))
202 self.checkWarningWithSingleItem(warnings[0], 'SDK', _SDK_BUILD_FILE, 2) 202 self.checkWarningWithSingleItem(warnings[0], 'SDK', _SDK_BUILD_FILE, 2)
203 203
204 def testPythonSourceSetInSDKBuildFile(self):
205 """Tests that a python_binary_source_set within an SDK buildfile is
206 accepted."""
207 mock_input_api = self.inputApiContainingFileWithSourceSets(
208 _SDK_BUILD_FILE,
209 [ 'mojo_sdk_source_set(', 'python_binary_source_set(' ])
210 warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi())
211
212 self.assertEqual(0, len(warnings))
213
204 def testEDKSourceSetInSDKBuildFile(self): 214 def testEDKSourceSetInSDKBuildFile(self):
205 """Tests that a mojo_edk_source_set within an SDK buildfile is flagged.""" 215 """Tests that a mojo_edk_source_set within an SDK buildfile is flagged."""
206 mock_input_api = self.inputApiContainingFileWithSourceSets( 216 mock_input_api = self.inputApiContainingFileWithSourceSets(
207 _SDK_BUILD_FILE, 217 _SDK_BUILD_FILE,
208 [ 'mojo_sdk_source_set(', 'mojo_edk_source_set(' ]) 218 [ 'mojo_sdk_source_set(', 'mojo_edk_source_set(' ])
209 warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi()) 219 warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi())
210 220
211 self.assertEqual(1, len(warnings)) 221 self.assertEqual(1, len(warnings))
212 self.checkWarningWithSingleItem(warnings[0], 'SDK', _SDK_BUILD_FILE, 2) 222 self.checkWarningWithSingleItem(warnings[0], 'SDK', _SDK_BUILD_FILE, 2)
213 223
(...skipping 20 matching lines...) Expand all
234 def testIrrelevantBuildFile(self): 244 def testIrrelevantBuildFile(self):
235 """Tests that a source_set in a non-SDK/EDK buildfile isn't flagged.""" 245 """Tests that a source_set in a non-SDK/EDK buildfile isn't flagged."""
236 mock_input_api = self.inputApiContainingFileWithSourceSets( 246 mock_input_api = self.inputApiContainingFileWithSourceSets(
237 _IRRELEVANT_BUILD_FILE, 247 _IRRELEVANT_BUILD_FILE,
238 [ 'source_set(' ]) 248 [ 'source_set(' ])
239 warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi()) 249 warnings = PRESUBMIT._BuildFileChecks(mock_input_api, MockOutputApi())
240 self.assertEqual(0, len(warnings)) 250 self.assertEqual(0, len(warnings))
241 251
242 if __name__ == '__main__': 252 if __name__ == '__main__':
243 unittest.main() 253 unittest.main()
OLDNEW
« mojo/PRESUBMIT.py ('K') | « mojo/PRESUBMIT.py ('k') | mojo/public/python/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698