Use Blink's flag to prevent fling boosting.

Use Blink's flag to prevent fling boosting.

This flag prevents the flingCancel event from being used
as a part of a fling boost event sequence.
The synthetic FlingCancel method works properly now and cancels flings
instantly, without deferring flingCancel event.

See: https://codereview.chromium.org/789223002

BUG=440886
Committed: https://crrev.com/b6c0ec4b3a2aab896c2ace17d1fec5db729bad17
Cr-Commit-Position: refs/heads/master@{#308599}

[wjarosik, 2014-12-10 15:12:54]

wjarosik@opera.com changed reviewers:
+ jdduke@chromium.org

[jdduke (slow), 2014-12-10 19:02:52]

Looks good, one point.

https://codereview.chromium.org/792833002/diff/1/content/renderer/input/input...
File content/renderer/input/input_handler_proxy.cc (right):

https://codereview.chromium.org/792833002/diff/1/content/renderer/input/input...
content/renderer/input/input_handler_proxy.cc:538: if
(gesture_event.data.flingCancel.preventBoosting)
Awesome, could you add a short test in input_handler_proxy_unittest.cc? There
are a number of existing tests of the form |NoFlingBoostIf*| there already, you
can basically just copy one of those and update the preventBoosting bit and make
sure it does the right thing. The |NoFlingBoostIfFlingTooSlow| code is probably
most similar to how you want to structure the test.

[wjarosik, 2014-12-11 16:43:14]

On 2014/12/10 19:02:52, jdduke wrote:
> Looks good, one point.
> 
>
https://codereview.chromium.org/792833002/diff/1/content/renderer/input/input...
> File content/renderer/input/input_handler_proxy.cc (right):
> 
>
https://codereview.chromium.org/792833002/diff/1/content/renderer/input/input...
> content/renderer/input/input_handler_proxy.cc:538: if
> (gesture_event.data.flingCancel.preventBoosting)
> Awesome, could you add a short test in input_handler_proxy_unittest.cc? There
> are a number of existing tests of the form |NoFlingBoostIf*| there already,
you
> can basically just copy one of those and update the preventBoosting bit and
make
> sure it does the right thing. The |NoFlingBoostIfFlingTooSlow| code is
probably
> most similar to how you want to structure the test.

Unit test added. I've done it in a simplest way to differentiate true/false flag
cases.

[jdduke (slow), 2014-12-11 16:59:10]

On 2014/12/11 16:43:30, wjarosik wrote:

Great, this lgtm, have you signed CLA?
https://code.google.com/legal/corporate-cla-v1.0.html?

[jdduke (slow), 2014-12-11 23:51:22]

Nevermind about the CLA, Opera is already an official contributor (I didn't
realize, but there's a *@opera.com entry in the src/AUTHORS file already, so
you're all set!).

You'll just need to wait until the Blink change lands and rolls to Chromium.

[wjarosik, 2014-12-12 11:06:04]

On 2014/12/11 23:51:22, jdduke wrote:
> Nevermind about the CLA, Opera is already an official contributor (I didn't
> realize, but there's a mailto:*@opera.com entry in the src/AUTHORS file
already, so
> you're all set!).
> 
> You'll just need to wait until the Blink change lands and rolls to Chromium.

All right. Thanks a lot!

[jdduke (slow), 2014-12-16 16:01:41]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:02:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792833002/20001

[commit-bot: I haz the power, 2014-12-16 16:52:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-16 16:53:29]

Patchset 2 (id:??) landed as
https://crrev.com/b6c0ec4b3a2aab896c2ace17d1fec5db729bad17
Cr-Commit-Position: refs/heads/master@{#308599}