components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc - Issue 792803007: Make Data Reduction Proxy a best effort proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

Issue 792803007: Make Data Reduction Proxy a best effort proxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

index bfef9e731dba9be6a89018b7fafdfa3147969457..7eeca8f1ed1396b6c38dcbd12048ae989fed90d7 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

@@ -149,8 +149,7 @@ void OnResolveProxyHandler(const GURL& url,

const DataReductionProxyParams* params,

net::ProxyInfo* result) {

if (data_reduction_proxy_config.is_valid() &&

- result->proxy_server().is_direct() &&

- !data_reduction_proxy_config.Equals(proxy_service_proxy_config)) {

+ result->proxy_server().is_direct()) {

net::ProxyInfo data_reduction_proxy_info;

data_reduction_proxy_config.proxy_rules().Apply(

url, &data_reduction_proxy_info);