Source/core/paint/BlockPainter.cpp - Issue 792803002: [New Multicolumn] Layout support for column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/BlockPainter.cpp

Issue 792803002: [New Multicolumn] Layout support for column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@347325-placeholder

Patch Set: rebase master Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/span/with-border-expected.html ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/BlockPainter.cpp

diff --git a/Source/core/paint/BlockPainter.cpp b/Source/core/paint/BlockPainter.cpp

index 8b1b93a4b19a3f2fac0433cacce6685f1b73103b..a6ae89ae79b2f506964d667ef3953318cd6e569d 100644

--- a/Source/core/paint/BlockPainter.cpp

+++ b/Source/core/paint/BlockPainter.cpp

@@ -100,7 +100,7 @@ void BlockPainter::paintChildren(const PaintInfo& paintInfo, const LayoutPoint&

void BlockPainter::paintChild(RenderBox* child, const PaintInfo& paintInfo, const LayoutPoint& paintOffset)

{

LayoutPoint childPoint = m_renderBlock.flipForWritingModeForChild(child, paintOffset);

- if (!child->hasSelfPaintingLayer() && !child->isFloating())

+ if (!child->hasSelfPaintingLayer() && !child->isFloating() && !child->isColumnSpanAll())

child->paint(paintInfo, childPoint);

}