Issue 792783006: Define SDKROOT for Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 792783006: Define SDKROOT for Mac (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)

Modified:
6 years ago

Reviewers:
Nico, adamk

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Define SDKROOT for Mac otherwise, the clang we ship doesn't work BUG=none R=adamk@chromium.org,thakis@chromium.org LOG=n Committed: https://crrev.com/333a92bd5e1ed52594325ee0db4e411899a3bfcd Cr-Commit-Position: refs/heads/master@{#25893}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/standalone.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

adamk

lgtm, in the sense that if this works, it sounds good to me! I'm sure ...

6 years ago (2014-12-18 20:13:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792783006/1

6 years ago (2014-12-18 20:16:21 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-18 20:42:59 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/333a92bd5e1ed52594325ee0db4e411899a3bfcd
Cr-Commit-Position: refs/heads/master@{#25893}