CSS Parser: Implement selector parsing (pseudo-classes/elements) [3/3]

CSS Parser: Implement selector parsing (pseudo-classes/elements) [3/3]

This patch continues implementation of CSS selector parsing with
css-syntax tokens. This adds support for parsing most pseudo-classes and
pseudo-elements, leaving out :lang and :nth-*.

http://dev.w3.org/csswg/selectors4/#grammar

BUG=330389
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187850

[Timothy Loh, 2014-12-10 07:30:38]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org

[Timothy Loh, 2014-12-10 07:30:38]

Part 1: https://codereview.chromium.org/790593004/
Part 2: https://codereview.chromium.org/747283003/

[alancutter (OOO until 2018), 2014-12-29 02:53:01]

lgtm after whitespace issues are resolved.

https://codereview.chromium.org/792763003/diff/80001/Source/core/css/parser/C...
File Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/792763003/diff/80001/Source/core/css/parser/C...
Source/core/css/parser/CSSSelectorParser.cpp:294: if (!selectorList->isValid()
|| (!m_tokenRange.atEnd() && m_tokenRange.consumeIncludingComments().type() !=
RightParenthesisToken))
consumeCompoundSelectorList does not consume trailing whitespace, you'll need to
consume whitespace before checking for ')'.

https://codereview.chromium.org/792763003/diff/80001/Source/core/css/parser/C...
Source/core/css/parser/CSSSelectorParser.cpp:310: if (!m_tokenRange.atEnd() &&
m_tokenRange.consumeIncludingComments().type() != RightParenthesisToken)
consumeCompoundSelector does not consume trailing whitespace, you'll need to
consume whitespace before checking for ')'.

[Timothy Loh, 2015-01-05 05:24:52]

https://codereview.chromium.org/792763003/diff/80001/Source/core/css/parser/C...
File Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/792763003/diff/80001/Source/core/css/parser/C...
Source/core/css/parser/CSSSelectorParser.cpp:294: if (!selectorList->isValid()
|| (!m_tokenRange.atEnd() && m_tokenRange.consumeIncludingComments().type() !=
RightParenthesisToken))
On 2014/12/29 02:53:01, alancutter wrote:
> consumeCompoundSelectorList does not consume trailing whitespace, you'll need
to
> consume whitespace before checking for ')'.

Updated consumeCompoundSelectorList to consume trailing whitespace (this is as
per spec, compound_selector_list : compound_selector S* [ COMMA S*
compound_selector ]* S*)

This is covered by fast/css/pseudo-any.html.

[Timothy Loh, 2015-01-05 05:24:59]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2015-01-05 05:25:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792763003/100001

[commit-bot: I haz the power, 2015-01-05 07:23:29]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187850