Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792733003: Fix mirror-script and debug tests when using external natives. (Closed)

Created:
6 years ago by vogelheim
Modified:
6 years ago
Reviewers:
yangguo, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix mirror-script and debug-script tests when using external natives. R=yangguo BUG=

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/natives-external.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vogelheim
6 years ago (2014-12-10 13:56:01 UTC) #2
Yang
On 2014/12/10 13:56:01, vogelheim wrote: lgtm!
6 years ago (2014-12-10 13:57:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792733003/20001
6 years ago (2014-12-10 15:39:16 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 16:06:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698