Add type annotations to gallery/js/image_editor/image_view.js.

Add type annotations to gallery/js/image_editor/image_view.js.

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "image_view.js"

Committed: https://crrev.com/abf6dd6e431251029bd92f9b46af41fe217a21dd
Cr-Commit-Position: refs/heads/master@{#307657}

[yawano, 2014-12-10 01:25:18]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2014-12-10 01:25:18]

PTAL. Thanks!

[fukino, 2014-12-10 02:54:19]

Thanks!

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/g...
File ui/file_manager/gallery/js/gallery_item.js (right):

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/g...
ui/file_manager/gallery/js/gallery_item.js:49: * @type
{(HTMLCanvasElement|Image)}
You can use HTMLImageElement instead of Image.
Could you use HTMLImageElement consistently here and other places?
see: https://developer.mozilla.org/en/docs/Web/API/HTMLImageElement.Image

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_view.js (right):

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_view.js:769: * @return
{?ImageView.Effect} Reversed effect. Null is returned if this
'?' is redundant

[yawano, 2014-12-10 06:02:50]

Thank you for the review. PTAL.

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/g...
File ui/file_manager/gallery/js/gallery_item.js (right):

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/g...
ui/file_manager/gallery/js/gallery_item.js:49: * @type
{(HTMLCanvasElement|Image)}
On 2014/12/10 02:54:19, fukino wrote:
> You can use HTMLImageElement instead of Image.
> Could you use HTMLImageElement consistently here and other places?
> see: https://developer.mozilla.org/en/docs/Web/API/HTMLImageElement.Image

Done.

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_view.js (right):

https://codereview.chromium.org/792733002/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_view.js:769: * @return
{?ImageView.Effect} Reversed effect. Null is returned if this
On 2014/12/10 02:54:19, fukino wrote:
> '?' is redundant

Done.

[fukino, 2014-12-10 07:19:37]

Thanks! lgtm.

[yawano, 2014-12-10 07:20:48]

Thank you.

On 2014/12/10 07:19:37, fukino wrote:
> Thanks! lgtm.

[yawano, 2014-12-10 07:20:52]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-12-10 07:21:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792733002/40001

[commit-bot: I haz the power, 2014-12-10 08:07:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-10 08:08:07]

Patchset 3 (id:??) landed as
https://crrev.com/abf6dd6e431251029bd92f9b46af41fe217a21dd
Cr-Commit-Position: refs/heads/master@{#307657}