Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4403)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

Issue 79273002: Fixed accessibility issues in bookmark bubble dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
index 89c979e54f69928cc078d1b15535493b04f2b4c3..b03d29631a0386a072bbf19c11fc96394c0706ef 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
@@ -23,6 +23,7 @@
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
+#include "ui/base/accessibility/accessible_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/events/event.h"
#include "ui/views/background.h"
@@ -163,6 +164,12 @@ bool BookmarkEditorView::HandleKeyEvent(views::Textfield* sender,
return false;
}
+void BookmarkEditorView::GetAccessibleState(ui::AccessibleViewState* state) {
+ state->name =
+ l10n_util::GetStringUTF16(IDS_BOOKMARK_EDITOR_TITLE);
+ state->role = ui::AccessibilityTypes::ROLE_DIALOG;
+}
+
void BookmarkEditorView::ButtonPressed(views::Button* sender,
const ui::Event& event) {
DCHECK_EQ(new_folder_button_.get(), sender);
@@ -272,7 +279,8 @@ void BookmarkEditorView::Init() {
title_tf_ = new views::Textfield;
title_tf_->SetText(title);
title_tf_->SetController(this);
- title_tf_->SetAccessibleName(title_label_->text());
+ title_tf_->SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_EDITOR_NAME_LABEL));
if (show_tree_) {
tree_view_ = new views::TreeView;
@@ -328,7 +336,8 @@ void BookmarkEditorView::Init() {
profile_ ? user_prefs::UserPrefs::Get(profile_) : NULL;
url_tf_->SetText(chrome::FormatBookmarkURLForDisplay(url, prefs));
url_tf_->SetController(this);
- url_tf_->SetAccessibleName(url_label_->text());
+ url_tf_->SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_EDITOR_URL_LABEL));
layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);

Powered by Google App Engine
This is Rietveld 408576698