Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc

Issue 79273002: Fixed accessibility issues in bookmark bubble dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
diff --git a/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc b/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
index 25b0feff746b5acf26b8c30aa039d72fa4cf8b99..3d7e00daee0e46bb2db9cb7a919a1530ed698afe 100644
--- a/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
+++ b/chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
@@ -395,9 +395,11 @@ std::string AccessibilityEventRouterViews::GetViewContext(views::View* view) {
// Two cases are handled right now. More could be added in the future
// depending on how the UI evolves.
- // A control in a toolbar should use the toolbar's accessible name
+ // A control in alert, toolbar or dialog should use the its accessible name
David Tseng 2013/11/20 22:13:27 s/the its/its. Perhaps rephrase // A control
zel 2013/11/21 00:19:23 Done.
// as the context.
- if (state.role == ui::AccessibilityTypes::ROLE_TOOLBAR &&
+ if ((state.role == ui::AccessibilityTypes::ROLE_ALERT ||
+ state.role == ui::AccessibilityTypes::ROLE_DIALOG ||
+ state.role == ui::AccessibilityTypes::ROLE_TOOLBAR) &&
!state.name.empty()) {
return UTF16ToUTF8(state.name);
}

Powered by Google App Engine
This is Rietveld 408576698