Enables font-related unittests again.

ui/gfx/font_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/font.h"
 
 #include "base/strings/string16.h"
+#include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_LINUX) && !defined(USE_OZONE)
 #include <pango/pango.h>
 #elif defined(OS_WIN)
 #include "ui/gfx/platform_font_win.h"
 #endif
 
 namespace gfx {
@@ skipping 38 matching lines @@
 #endif  // defined(OS_WIN)
 
 
 TEST_F(FontTest, LoadArial) {
   Font cf("Arial", 16);
   NativeFont native = cf.GetNativeFont();
   EXPECT_TRUE(native);
   EXPECT_EQ(cf.GetStyle(), Font::NORMAL);
   EXPECT_EQ(cf.GetFontSize(), 16);
   EXPECT_EQ(cf.GetFontName(), "Arial");
+  EXPECT_EQ("arial", StringToLowerASCII(cf.GetActualFontName()));
   FreeIfNecessary(native);
 }
 
 TEST_F(FontTest, LoadArialBold) {
   Font cf("Arial", 16);
   Font bold(cf.DeriveFont(0, Font::BOLD));
   NativeFont native = bold.GetNativeFont();
   EXPECT_TRUE(native);
   EXPECT_EQ(bold.GetStyle(), Font::BOLD);
+  EXPECT_EQ("arial", StringToLowerASCII(cf.GetActualFontName()));
   FreeIfNecessary(native);
 }
 
 TEST_F(FontTest, Ascent) {
   Font cf("Arial", 16);
   EXPECT_GT(cf.GetBaseline(), 2);
   EXPECT_LE(cf.GetBaseline(), 22);
 }
 
 TEST_F(FontTest, Height) {
@@ skipping 31 matching lines @@
   Font cf("Arial", 16);
   EXPECT_EQ(cf.GetStringWidth(base::string16()), 0);
   EXPECT_GT(cf.GetStringWidth(ASCIIToUTF16("a")),
             cf.GetStringWidth(base::string16()));
   EXPECT_GT(cf.GetStringWidth(ASCIIToUTF16("ab")),
             cf.GetStringWidth(ASCIIToUTF16("a")));
   EXPECT_GT(cf.GetStringWidth(ASCIIToUTF16("abc")),
             cf.GetStringWidth(ASCIIToUTF16("ab")));
 }
 
+#if !defined(OS_WIN)
+// On Windows, Font::GetActualFontName() doesn't work well for now.

[msw, 2013/12/09 19:27:15]

nit: file an issue to follow up.

[Yuki, 2013/12/10 09:58:59]

Done.

+TEST_F(FontTest, GetActualFontName) {
+  Font arial("Arial", 16);
+  EXPECT_EQ("arial", StringToLowerASCII(arial.GetActualFontName()));
+  Font symbol("Symbol", 16);
+  EXPECT_EQ("symbol", StringToLowerASCII(symbol.GetActualFontName()));
+
+  const char* const invalid_font_name = "no_such_a_font_name";

[msw, 2013/12/09 19:27:15]

nit: consider "invalid_font_name" or "no_such_font_name"

[Yuki, 2013/12/10 09:58:59]

Done.

+  Font fallback_font(invalid_font_name, 16);
+  EXPECT_NE(invalid_font_name,
+            StringToLowerASCII(fallback_font.GetActualFontName()));
+}
+#endif
+
 #if defined(OS_WIN)
 TEST_F(FontTest, DeriveFontResizesIfSizeTooSmall) {
   Font cf("Arial", 8);
   // The minimum font size is set to 5 in browser_main.cc.
   ScopedMinimumFontSizeCallback minimum_size(5);
 
   Font derived_font = cf.DeriveFont(-4);
   EXPECT_EQ(5, derived_font.GetFontSize());
 }
 
 TEST_F(FontTest, DeriveFontKeepsOriginalSizeIfHeightOk) {
   Font cf("Arial", 8);
   // The minimum font size is set to 5 in browser_main.cc.
   ScopedMinimumFontSizeCallback minimum_size(5);
 
   Font derived_font = cf.DeriveFont(-2);
   EXPECT_EQ(6, derived_font.GetFontSize());
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace
 }  // namespace gfx