Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Side by Side Diff: ui/gfx/render_text_unittest.cc

Issue 79263004: Enables font-related unittests again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gfx/render_text.h" 5 #include "ui/gfx/render_text.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 1138 matching lines...) Expand 10 before | Expand all | Expand 10 after
1149 EXPECT_EQ(font_list.GetHeight(), render_text->GetStringSize().height()); 1149 EXPECT_EQ(font_list.GetHeight(), render_text->GetStringSize().height());
1150 EXPECT_EQ(0, render_text->GetStringSize().width()); 1150 EXPECT_EQ(0, render_text->GetStringSize().width());
1151 EXPECT_EQ(font_list.GetBaseline(), render_text->GetBaseline()); 1151 EXPECT_EQ(font_list.GetBaseline(), render_text->GetBaseline());
1152 1152
1153 render_text->SetText(UTF8ToUTF16(" ")); 1153 render_text->SetText(UTF8ToUTF16(" "));
1154 EXPECT_EQ(font_list.GetHeight(), render_text->GetStringSize().height()); 1154 EXPECT_EQ(font_list.GetHeight(), render_text->GetStringSize().height());
1155 EXPECT_EQ(font_list.GetBaseline(), render_text->GetBaseline()); 1155 EXPECT_EQ(font_list.GetBaseline(), render_text->GetBaseline());
1156 } 1156 }
1157 #endif // !defined(OS_MACOSX) 1157 #endif // !defined(OS_MACOSX)
1158 1158
1159 // Disabled. http://crbug.com/316955 1159 TEST_F(RenderTextTest, StringSizeRespectsFontListMetrics) {
1160 TEST_F(RenderTextTest, DISABLED_StringSizeRespectsFontListMetrics) {
1161 // Check that Arial and Symbol have different font metrics. 1160 // Check that Arial and Symbol have different font metrics.
1162 Font arial_font("Arial", 16); 1161 Font arial_font("Arial", 16);
1163 Font symbol_font("Symbol", 16); 1162 Font symbol_font("Symbol", 16);
1164 EXPECT_NE(arial_font.GetHeight(), symbol_font.GetHeight()); 1163 EXPECT_NE(arial_font.GetHeight(), symbol_font.GetHeight());
1165 EXPECT_NE(arial_font.GetBaseline(), symbol_font.GetBaseline()); 1164 EXPECT_NE(arial_font.GetBaseline(), symbol_font.GetBaseline());
1166 // "a" should be rendered with Arial, not with Symbol. 1165 // "a" should be rendered with Arial, not with Symbol.
1167 const char* arial_font_text = "a"; 1166 const char* arial_font_text = "a";
1168 // "®" (registered trademark symbol) should be rendered with Symbol, 1167 // "®" (registered trademark symbol) should be rendered with Symbol,
1169 // not with Arial. 1168 // not with Arial.
1170 const char* symbol_font_text = "\xC2\xAE"; 1169 const char* symbol_font_text = "\xC2\xAE";
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 EXPECT_EQ(font_list.GetBaseline(), render_text->GetBaseline()); 1205 EXPECT_EQ(font_list.GetBaseline(), render_text->GetBaseline());
1207 } 1206 }
1208 1207
1209 TEST_F(RenderTextTest, SetFont) { 1208 TEST_F(RenderTextTest, SetFont) {
1210 scoped_ptr<RenderText> render_text(RenderText::CreateInstance()); 1209 scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
1211 render_text->SetFont(Font("Arial", 12)); 1210 render_text->SetFont(Font("Arial", 12));
1212 EXPECT_EQ("Arial", render_text->GetPrimaryFont().GetFontName()); 1211 EXPECT_EQ("Arial", render_text->GetPrimaryFont().GetFontName());
1213 EXPECT_EQ(12, render_text->GetPrimaryFont().GetFontSize()); 1212 EXPECT_EQ(12, render_text->GetPrimaryFont().GetFontSize());
1214 } 1213 }
1215 1214
1216 // Disabled. http://crbug.com/316955 1215 TEST_F(RenderTextTest, SetFontList) {
1217 TEST_F(RenderTextTest, DISABLED_SetFontList) {
1218 scoped_ptr<RenderText> render_text(RenderText::CreateInstance()); 1216 scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
1219 render_text->SetFontList(FontList("Arial,Symbol, 13px")); 1217 render_text->SetFontList(FontList("Arial,Symbol, 13px"));
1220 const std::vector<Font>& fonts = render_text->font_list().GetFonts(); 1218 const std::vector<Font>& fonts = render_text->font_list().GetFonts();
1221 ASSERT_EQ(2U, fonts.size()); 1219 ASSERT_EQ(2U, fonts.size());
1222 EXPECT_EQ("Arial", fonts[0].GetFontName()); 1220 EXPECT_EQ("Arial", fonts[0].GetFontName());
1223 EXPECT_EQ("Symbol", fonts[1].GetFontName()); 1221 EXPECT_EQ("Symbol", fonts[1].GetFontName());
1224 EXPECT_EQ(13, render_text->GetPrimaryFont().GetFontSize()); 1222 EXPECT_EQ(13, render_text->GetPrimaryFont().GetFontSize());
1225 } 1223 }
1226 1224
1227 TEST_F(RenderTextTest, StringSizeBoldWidth) { 1225 TEST_F(RenderTextTest, StringSizeBoldWidth) {
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
1748 render_text->SetText(WideToUTF16(L"x \x25B6 y")); 1746 render_text->SetText(WideToUTF16(L"x \x25B6 y"));
1749 render_text->EnsureLayout(); 1747 render_text->EnsureLayout();
1750 ASSERT_EQ(3U, render_text->runs_.size()); 1748 ASSERT_EQ(3U, render_text->runs_.size());
1751 EXPECT_EQ(Range(0, 2), render_text->runs_[0]->range); 1749 EXPECT_EQ(Range(0, 2), render_text->runs_[0]->range);
1752 EXPECT_EQ(Range(2, 3), render_text->runs_[1]->range); 1750 EXPECT_EQ(Range(2, 3), render_text->runs_[1]->range);
1753 EXPECT_EQ(Range(3, 5), render_text->runs_[2]->range); 1751 EXPECT_EQ(Range(3, 5), render_text->runs_[2]->range);
1754 } 1752 }
1755 #endif // defined(OS_WIN) 1753 #endif // defined(OS_WIN)
1756 1754
1757 } // namespace gfx 1755 } // namespace gfx
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698