Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 792623002: egl: Don't query EGL_POST_SUB_BUFFER_SUPPORTED_NV without extension (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, achaulk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

egl: Don't query EGL_POST_SUB_BUFFER_SUPPORTED_NV without extension We should only query the surface for this feature if the requisite extension is supported. Querying has incorrect results with llvmpipe on ubuntu trusty, which doesn't support the extension. BUG=440473 TEST=chrome --use-gl=egl (chromeos build) - no partial swap errors Committed: https://crrev.com/9d1c8ff57b7042918cc5f81b2cd37d974df2e557 Cr-Commit-Position: refs/heads/master@{#307588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/gl/gl_surface_egl.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years ago (2014-12-09 19:31:20 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
6 years ago (2014-12-09 22:18:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792623002/1
6 years ago (2014-12-09 22:53:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 23:57:25 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-09 23:58:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d1c8ff57b7042918cc5f81b2cd37d974df2e557
Cr-Commit-Position: refs/heads/master@{#307588}

Powered by Google App Engine
This is Rietveld 408576698