[Sync] Move change-related methods out of SyncManager::Observer

chrome/browser/sync/internal_api/change_record_unittest.cc

Index: chrome/browser/sync/internal_api/change_record_unittest.cc
diff --git a/chrome/browser/sync/internal_api/change_record_unittest.cc b/chrome/browser/sync/internal_api/change_record_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a3ea06acb76fa51d40d4f15f1aa6a8879f4d7a16
--- /dev/null
+++ b/chrome/browser/sync/internal_api/change_record_unittest.cc
@@ -0,0 +1,137 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/sync/internal_api/change_record.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/string_number_conversions.h"
+#include "base/values.h"
+#include "chrome/browser/sync/protocol/extension_specifics.pb.h"
+#include "chrome/browser/sync/protocol/proto_value_conversions.h"
+#include "chrome/browser/sync/protocol/sync.pb.h"
+#include "chrome/test/base/values_test_util.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace sync_api {
+namespace {
+
+using test::ExpectDictDictionaryValue;
+using test::ExpectDictStringValue;
+using testing::Invoke;
+using testing::StrictMock;
+
+class ChangeRecordTest : public testing::Test {};
+
+void ExpectChangeRecordActionValue(ChangeRecord::Action expected_value,
+                                   const base::DictionaryValue& value,
+                                   const std::string& key) {
+  std::string str_value;
+  EXPECT_TRUE(value.GetString(key, &str_value));
+  switch (expected_value) {
+    case ChangeRecord::ACTION_ADD:
+      EXPECT_EQ("Add", str_value);
+      break;
+    case ChangeRecord::ACTION_UPDATE:
+      EXPECT_EQ("Update", str_value);
+      break;
+    case ChangeRecord::ACTION_DELETE:
+      EXPECT_EQ("Delete", str_value);
+      break;
+    default:
+      NOTREACHED();
+      break;
+  }
+}
+
+void CheckChangeRecordValue(
+    const ChangeRecord& record,
+    const base::DictionaryValue& value) {
+  ExpectChangeRecordActionValue(record.action, value, "action");
+  ExpectDictStringValue(base::Int64ToString(record.id), value, "id");
+  if (record.action == ChangeRecord::ACTION_DELETE) {
+    scoped_ptr<base::DictionaryValue> expected_extra_value;
+    if (record.extra.get()) {
+      expected_extra_value.reset(record.extra->ToValue());
+    }
+    base::Value* extra_value = NULL;
+    EXPECT_EQ(record.extra.get() != NULL,
+              value.Get("extra", &extra_value));
+    EXPECT_TRUE(Value::Equals(extra_value, expected_extra_value.get()));
+
+    scoped_ptr<DictionaryValue> expected_specifics_value(
+        browser_sync::EntitySpecificsToValue(record.specifics));
+    ExpectDictDictionaryValue(*expected_specifics_value,
+                              value, "specifics");
+  }
+}
+
+class MockExtraChangeRecordData
+    : public ExtraPasswordChangeRecordData {
+ public:
+  MOCK_CONST_METHOD0(ToValue, DictionaryValue*());
+};
+
+TEST_F(ChangeRecordTest, ChangeRecordToValue) {
+  sync_pb::EntitySpecifics old_specifics;
+  old_specifics.MutableExtension(sync_pb::extension)->set_id("old");
+  sync_pb::EntitySpecifics new_specifics;
+  old_specifics.MutableExtension(sync_pb::extension)->set_id("new");
+
+  const int64 kTestId = 5;
+
+  // Add
+  {
+    ChangeRecord record;
+    record.action = ChangeRecord::ACTION_ADD;
+    record.id = kTestId;
+    record.specifics = old_specifics;
+    record.extra.reset(new StrictMock<MockExtraChangeRecordData>());
+    scoped_ptr<DictionaryValue> value(record.ToValue());
+    CheckChangeRecordValue(record, *value);
+  }
+
+  // Update
+  {
+    ChangeRecord record;
+    record.action = ChangeRecord::ACTION_UPDATE;
+    record.id = kTestId;
+    record.specifics = old_specifics;
+    record.extra.reset(new StrictMock<MockExtraChangeRecordData>());
+    scoped_ptr<DictionaryValue> value(record.ToValue());
+    CheckChangeRecordValue(record, *value);
+  }
+
+  // Delete (no extra)
+  {
+    ChangeRecord record;
+    record.action = ChangeRecord::ACTION_DELETE;
+    record.id = kTestId;
+    record.specifics = old_specifics;
+    scoped_ptr<DictionaryValue> value(record.ToValue());
+    CheckChangeRecordValue(record, *value);
+  }
+
+  // Delete (with extra)
+  {
+    ChangeRecord record;
+    record.action = ChangeRecord::ACTION_DELETE;
+    record.id = kTestId;
+    record.specifics = old_specifics;
+
+    DictionaryValue extra_value;
+    extra_value.SetString("foo", "bar");
+    scoped_ptr<StrictMock<MockExtraChangeRecordData> > extra(
+        new StrictMock<MockExtraChangeRecordData>());
+    EXPECT_CALL(*extra, ToValue()).Times(2).WillRepeatedly(
+        Invoke(&extra_value, &DictionaryValue::DeepCopy));
+
+    record.extra.reset(extra.release());
+    scoped_ptr<DictionaryValue> value(record.ToValue());
+    CheckChangeRecordValue(record, *value);
+  }
+}
+
+}  // namespace
+}  // namespace sync_api