Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 792563003: Fix messages tests. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix messages tests. Change tests so that message location is stable under --debug-code. R=yangguo@chromium.org BUG=v8:3744 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M test/message/message.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/message/super-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/super-constructor.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/super-constructor-extra-statement.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/super-constructor-extra-statement.out View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Lomov (no reviews)
6 years ago (2014-12-09 16:22:15 UTC) #1
Yang
On 2014/12/09 16:22:15, Dmitry Lomov (chromium) wrote: lgtm.
6 years ago (2014-12-09 16:23:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792563003/1
6 years ago (2014-12-09 16:28:30 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-10 08:54:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698