Issue 792563002: Revert of Use same blob format for internal and external snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 792563002: Revert of Use same blob format for internal and external snapshots. (Closed)

Created:
6 years ago by Michael Achenbach

Modified:
6 years ago

Reviewers:
vogelheim, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Revert of Use same blob format for internal and external snapshots. (patchset #2 id:20001 of https://codereview.chromium.org/787033002/) Reason for revert: [sheriff] breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1293 Original issue's description: > Use same blob format for internal and external snapshots. > > R=vogelheim@chromium.org TBR=vogelheim@chromium.org,yangguo@chromium.org NOTREECHECKS=true NOTRY=true

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -129 lines)			Patch
M	BUILD.gn	View	3 chunks	+2 lines, -1 line	0 comments	Download
M	Makefile	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/mksnapshot.cc	View	5 chunks	+64 lines, -28 lines	0 comments	Download
M	src/natives-external.cc	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	src/serialize.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/snapshot.h	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	src/snapshot-common.cc	View	2 chunks	+31 lines, -42 lines	0 comments	Download
M	src/snapshot-empty.cc	View	1 chunk	+4 lines, -13 lines	0 comments	Download
M	src/snapshot-external.cc	View	1 chunk	+55 lines, -17 lines	0 comments	Download
M	src/snapshot-source-sink.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	3 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Created Revert of Use same blob format for internal and external snapshots.

6 years ago (2014-12-09 16:18:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792563002/1

6 years ago (2014-12-09 16:19:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)