Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/checklicenses/checklicenses.py

Issue 7925024: Prepare checklicenses.py for buildbot landing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/checklicenses/checklicenses.py
diff --git a/tools/checklicenses/checklicenses.py b/tools/checklicenses/checklicenses.py
index 2ed79ff8cdb72f5b3443530f0f908b4b5ca74221..0bd79d02d86082c34eb5fb914c3dd012f6c54a4a 100755
--- a/tools/checklicenses/checklicenses.py
+++ b/tools/checklicenses/checklicenses.py
@@ -132,6 +132,9 @@ PATH_SPECIFIC_WHITELISTED_LICENSES = {
'ppapi/lib/gl/include': [
'UNKNOWN',
],
+ 'ppapi/native_client/tests/earth/earth_image.inc': [
+ 'UNKNOWN',
+ ],
'remoting/tools/gethosts.sh': [
'UNKNOWN',
],
@@ -416,6 +419,7 @@ def main(options, args):
print "Using base directory:", options.base_directory
print "Checking:", start_dir
+ print
licensecheck_path = os.path.abspath(os.path.join(options.base_directory,
'third_party',
@@ -474,7 +478,16 @@ def main(options, args):
sys.exit(0)
else:
print "\nFAILED\n"
- sys.exit(1)
+ print "Please read",
+ print "http://www.chromium.org/developers/adding-3rd-party-libraries"
+ print "for more info how to handle the failure."
+ print
+ print "Please respect OWNERS of checklicenses.py. Changes violating"
+ print "this requirement may be reverted."
+
+ # TODO(phajdan.jr): Switch back to exit(1) when it lands on buildbot.
+ # 88 is buildbot "warning" code, it doesn't turn the step red but orange.
+ sys.exit(88)
if '__main__' == __name__:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698