Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Unified Diff: mojo/public/cpp/application/application_test_base.h

Issue 792463007: Allow ApplicationTestBase clients to avoid a default MessageLoop. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/application/application_test_base.h
diff --git a/mojo/public/cpp/application/application_test_base.h b/mojo/public/cpp/application/application_test_base.h
index 04580c76893a5cb1de23a895c9be6ae40ad69a28..c355117e6e5d2887763fb18a26079d2fad3b637f 100644
--- a/mojo/public/cpp/application/application_test_base.h
+++ b/mojo/public/cpp/application/application_test_base.h
@@ -45,6 +45,11 @@ class ApplicationTestBase : public testing::Test {
void SetUp() override;
void TearDown() override;
+ // True by default, which indicates a MessageLoop will automatically be
+ // created for the application. Tests may override this function to prevent
+ // a default loop from being created.
+ virtual bool IsDefaultLoopEnabled();
sky 2014/12/16 03:47:36 This name is a bit confusing. How about ShouldCrea
DaleCurtis 2014/12/16 19:26:12 Done.
+
private:
// The application implementation instance, reconstructed for each test.
ApplicationImpl* application_impl_;

Powered by Google App Engine
This is Rietveld 408576698