Issue 792443004: Upstream WeakNSObject in //base/ios

Issue 792443004: Upstream WeakNSObject in //base/ios (Closed)

Created:
6 years ago by droger

Modified:
6 years ago

Reviewers:
stuartmorgan, Nico

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Upstream WeakNSObject in //base/ios Committed: https://crrev.com/c6762659cdcb0c0d3c2a430ae964ab04429253ca Cr-Commit-Position: refs/heads/master@{#308114}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+330 lines, -0 lines)			Patch
M	base/BUILD.gn	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	base/base.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	base/base.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	base/ios/weak_nsobject.h	View	1	1 chunk	+166 lines, -0 lines	0 comments	Download
A	base/ios/weak_nsobject.mm	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download
A	base/ios/weak_nsobject_unittest.mm	View		1 chunk	+97 lines, -0 lines	0 comments	Download

Total messages: 8 (2 generated)

droger

Reviewers: stuartmorgan for the upstreaming thakis for the gyp files

6 years ago (2014-12-12 13:02:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792443004/20001

6 years ago (2014-12-12 16:34:58 UTC) #6

commit-bot: I haz the power

6 years ago (2014-12-12 17:39:58 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/c6762659cdcb0c0d3c2a430ae964ab04429253ca
Cr-Commit-Position: refs/heads/master@{#308114}