Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792433003: Adding phoglund as shepherd for WebRTC browser tests. (Closed)

Created:
6 years ago by phoglund_chromium
Modified:
6 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding phoglund as shepherd for WebRTC browser tests. This is just a suggestion to reduce tommi's rubberstamping load. R=tommi@chromium.org BUG=None Committed: https://crrev.com/decf4361cef158c83e2b88369c5f25ab7154bc25 Cr-Commit-Position: refs/heads/master@{#308124}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Filtering on webrtc instead #

Total comments: 1

Patch Set 3 : Now matching both webrtc and test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/media/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
phoglund_chromium
6 years ago (2014-12-09 09:29:07 UTC) #1
tommi (sloooow) - chröme
https://codereview.chromium.org/792433003/diff/1/chrome/browser/media/OWNERS File chrome/browser/media/OWNERS (right): https://codereview.chromium.org/792433003/diff/1/chrome/browser/media/OWNERS#newcode14 chrome/browser/media/OWNERS:14: per-file *browsertest*=phoglund@google.com can we add 'webrtc' in there?
6 years ago (2014-12-09 14:05:17 UTC) #2
phoglund_chromium
PTAL https://codereview.chromium.org/792433003/diff/1/chrome/browser/media/OWNERS File chrome/browser/media/OWNERS (right): https://codereview.chromium.org/792433003/diff/1/chrome/browser/media/OWNERS#newcode14 chrome/browser/media/OWNERS:14: per-file *browsertest*=phoglund@google.com On 2014/12/09 14:05:17, tommi wrote: > ...
6 years ago (2014-12-09 14:46:38 UTC) #3
tommi (sloooow) - chröme
https://codereview.chromium.org/792433003/diff/20001/chrome/browser/media/OWNERS File chrome/browser/media/OWNERS (right): https://codereview.chromium.org/792433003/diff/20001/chrome/browser/media/OWNERS#newcode15 chrome/browser/media/OWNERS:15: per-file *webrtc*=phoglund@google.com any chance of combining webrtc and test?
6 years ago (2014-12-09 15:28:36 UTC) #4
phoglund_chromium
Sure. This still matches all files I care about.
6 years ago (2014-12-09 16:34:44 UTC) #5
phoglund_chromium
ping
6 years ago (2014-12-12 10:48:39 UTC) #6
tommi (sloooow) - chröme
lgtm oops, sorry, so much stuff going on.
6 years ago (2014-12-12 17:50:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792433003/40001
6 years ago (2014-12-12 17:51:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 18:31:36 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-12 18:33:05 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/decf4361cef158c83e2b88369c5f25ab7154bc25
Cr-Commit-Position: refs/heads/master@{#308124}

Powered by Google App Engine
This is Rietveld 408576698