Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 792383004: Run draw callback immediately if no Display is damaged. (Closed)

Created:
5 years, 11 months ago by jbauman
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run draw callback immediately if no Display is damaged. This may cause the draw callback to be run earlier than before if the Surface would later be added to a Display, but prevents it ensures that the callback runs if the Surface wouldn't be drawn at all BUG=440269 Committed: https://crrev.com/c247da12fcca15fdcc948024287b94d6e63e9784 Cr-Commit-Position: refs/heads/master@{#313212}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -33 lines) Patch
M cc/surfaces/display.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.cc View 1 2 3 4 5 4 chunks +13 lines, -2 lines 0 comments Download
M cc/surfaces/surface.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M cc/surfaces/surface.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M cc/surfaces/surface_damage_observer.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M cc/surfaces/surface_factory.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 1 2 3 2 chunks +9 lines, -8 lines 0 comments Download
M cc/surfaces/surface_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_manager.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/compositor/onscreen_display_client.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/surface_display_output_surface.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/surface_display_output_surface.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbauman
5 years, 11 months ago (2015-01-12 20:32:18 UTC) #2
jbauman
ping. This seems like one way to handle Surfaces that aren't aggregated in Displays. I ...
5 years, 11 months ago (2015-01-16 00:58:14 UTC) #3
jamesr
Yeah, this case is really tough. I think this could make scheduling hard when a ...
5 years, 11 months ago (2015-01-23 06:23:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792383004/100001
5 years, 11 months ago (2015-01-27 02:03:13 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-27 02:53:26 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 02:54:12 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c247da12fcca15fdcc948024287b94d6e63e9784
Cr-Commit-Position: refs/heads/master@{#313212}

Powered by Google App Engine
This is Rietveld 408576698