chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc - Issue 792353002: Refactoring of Cast-related crypto code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

Issue 792353002: Refactoring of Cast-related crypto code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed typo from https://codereview.chromium.org/747223002 Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/crypto_verify_impl.h ('k') | chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

diff --git a/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc b/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

index da34f3fed41a808aeb91af2df02247dd8de6f01f..1960a12d5903cd62262fd6d6d97e59afc07bcda2 100644

--- a/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

+++ b/chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc

@@ -38,8 +38,8 @@ bool DecodeAndVerifyCredentials(

return false;

}

*verified = networking_private_crypto::VerifyCredentials(

- credentials.certificate, decoded_signed_data, credentials.unsigned_data,

- credentials.device_bssid);

+ credentials.certificate, credentials.intermediate_certificates,

+ decoded_signed_data, credentials.unsigned_data, credentials.device_bssid);

return true;

}

@@ -158,6 +158,8 @@ void VerifyAndEncryptCredentialsCompleted(

CryptoVerifyImpl::Credentials::Credentials(

const VerificationProperties& properties) {

certificate = properties.certificate;

+ if (properties.intermediate_certificates.get())

+ intermediate_certificates = *properties.intermediate_certificates;

signed_data = properties.signed_data;

std::vector<std::string> data_parts;