Refactoring of Cast-related crypto code

extensions/common/cast/cast_cert_validator.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/common/cast/cast_cert_validator.h"
+
+namespace extensions {
+namespace core_api {
+namespace cast_crypto {
+
+VerificationResult::VerificationResult()
+    : error_type(ERROR_NONE), library_error_code(0) {

[mark a. foltz, 2014/12/18 00:43:42]

Consider using a delegated constructor here to reduce code duplication.

[sheretov, 2015/01/03 03:18:02]

It looks about as verbose, but with an unsightly temporary empty string object:
     : VerificationResult("", ERROR_NONE, 0) {
... and then If I want to understand what the parameters map to, I have to look
for the other constructor.

+}
+
+VerificationResult::VerificationResult(const std::string& in_error_message,
+                                       ErrorType in_error_type)
+    : error_type(in_error_type), error_message(in_error_message) {
+}
+
+VerificationResult::VerificationResult(const std::string& in_error_message,
+                                       ErrorType in_error_type,
+                                       int in_error_code)
+    : error_type(in_error_type),
+      error_message(in_error_message),
+      library_error_code(in_error_code) {
+}
+
+}  // namespace cast_crypto
+}  // namespace core_api
+}  // namespace extensions