Refactoring of Cast-related crypto code

chrome/common/extensions/api/networking_private.json

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 [
   {
     "namespace":"networkingPrivate",
     "description": "none",
     "compiler_options": {
       "implemented_in": "chrome/browser/extensions/api/networking_private/networking_private_api.h"
@@ skipping 11 matching lines @@
         "additionalProperties": { "type": "any" }
       },
       {
         "id": "VerificationProperties",
         "type": "object",
         "properties": {
           "certificate": {
             "type": "string",
             "description": "A string containing a PEM-encoded X.509 certificate for use in verifying the signed data."
           },
+          "intermediateCertificates": {
+            "type": "array",
+            "items": { "type": "string" },
+            "optional": true,
+            "description": "An array of PEM-encoded X.509 intermediate certificate authority certificates."

[Ryan Sleevi, 2014/12/15 21:42:59]

Documentation: PEM encoding can either mean with the PEM header/footer
("----BEGIN CERTIFICATE-----") or simply base-64 encoded. Because it's an array,
it's a bit ambiguous. It might help to documented this more explicitly (this is
sort of ambiguous in the other things too; for example, an RSA key can have the
form "PRIVATE KEY" or "RSA PRIVATE KEY" depending on the library you're using)

[sheretov, 2014/12/16 08:44:20]

Done.

Fixed the publicKey field's description as well.  It is a Base64-encoded
RSAPublicKey - not PEM-encoded.

+          },
           "publicKey": {
             "type": "string",
             "description": "A string containing a PEM-encoded RSA public key to be used to compare with the one in signedData"
           },
           "nonce": {
             "type": "string",
             "description": "A string containing a base64-encoded random binary data for use in verifying the signed data."
           },
           "signedData": {
             "type": "string",
@@ skipping 468 matching lines @@
           },
           {
             "name": "status",
             "$ref": "CaptivePortalStatus"
           }
         ]
       }
     ]
   }
 ]